fix repeat order by on query

[ilsyaa]

I have a problem here why the order by is repeated more than once

mycode

<?php

namespace App\Livewire\Tables;

use App\Models\Role;
use Rappasoft\LaravelLivewireTables\DataTableComponent;
use Rappasoft\LaravelLivewireTables\Views\Column;
use App\Models\User;
use Illuminate\Database\Eloquent\Builder;
use Rappasoft\LaravelLivewireTables\Views\Filters\MultiSelectFilter;
use Rappasoft\LaravelLivewireTables\Views\Filters\SelectFilter;

class UserTable extends DataTableComponent
{
    protected $model = User::class;

    public function configure(): void
    {
        $this->setPrimaryKey('id');
        $this->setEagerLoadAllRelationsStatus(true);
        $this->setAdditionalSelects(['*']); // showable columns
        $this->setQueryStringStatus(false);
        $this->debugStatus = true;
        $this->setSearchDebounce(700);
        $this->setDefaultSort('created_at', 'desc');

        // pagination
        $this->setPerPageAccepted([9, 10, 25, 50, 100]);
        // pagination

        // bulkActions
        $this->setHideBulkActionsWhenEmptyEnabled();
        $this->setDelaySelectAllEnabled();
        $this->setBulkActions([
            'deleteSelected' => 'Delete',
        ]);
        $this->setBulkActionConfirmMessages([
            'deleteSelected' => 'Are you sure you want to delete the selected users?',
        ]);
        // bulkActions
    }

    public function columns(): array
    {
        return [
            Column::make("Name", "name")
                ->view('admin.users.components.profile')
                ->searchable(function (Builder $query, string $term) {
                    $query->where('name', 'like', '%' . $term . '%')
                        ->orWhere('email', 'like', '%' . $term . '%')
                        ->orWhere('username', 'like', '%' . $term . '%');
                })
                ->sortable(),
            Column::make('Username', 'username')
                ->format(fn ($value) => '@' . $value),
            Column::make('Email verified at', 'email_verified_at')
                ->format(fn ($value) => $value ? $value->diffForHumans() : '<span class="text-gray-500 inline-flex justify-center items-center gap-x-1"><i class="fa-duotone fa-xmark"></i> Not Verified</span>')->html()
                ->sortable(),
            Column::make('Role')
                ->label(function ($row) {
                    $icon = '';
                    if ($row->roles->name == 'admin') {
                        $icon = '<i class="fa-duotone fa-shield-check"></i>';
                    } else if ($row->roles->name == 'writer') {
                        $icon = '<i class="fa-duotone fa-pen-to-square"></i>';
                    } else if ($row->roles->name == 'user') {
                        $icon = '<i class="fa-duotone fa-user"></i>';
                    }
                    return '<div class="inline-flex min-w-20 justify-center items-center gap-x-1 font-normal text-xs/none bg-indigo-500 text-white rounded-full px-2 py-1.5">'. $icon .\Str::ucfirst($row->roles->name ?? 'None') .'</div>';
                })
                ->html(),
            Column::make('Updated At', 'updated_at')
                ->format(fn ($value) => $value->format('d M, Y'))
                ->sortable(),
            Column::make("Member Since", "created_at")
                ->format(fn ($value) => $value->diffForHumans())
                ->sortable(),
            Column::make('Actions')
                ->label(fn ($row) => view('admin.users.components.actions', ['row' => $row]))
        ];
    }

    public function filters(): array
    {
        return [
            SelectFilter::make('E-mail Verified', 'email_verified_at')
                ->setFilterPillTitle('Verified')
                ->options([
                    ''    => 'All',
                    'yes' => 'Yes',
                    'no'  => 'No',
                ])
                ->filter(function($builder, $value) {
                    if ($value === 'yes') {
                        $builder->whereNotNull('email_verified_at');
                    } elseif ($value === 'no') {
                        $builder->whereNull('email_verified_at');
                    }
                }),
            MultiSelectFilter::make('Role', 'roles')
                ->setFilterPillTitle('Role')
                ->options(Role::all()->pluck('name')->mapWithKeys(fn ($role) => [$role => ucfirst($role)])->toArray())
                ->filter(function($builder, $value) {
                    $builder->whereHas('roles', function ($q) use ($value) {
                        $q->whereIn('name', $value);
                    });
                }),
        ];
    }

    public function deleteSelected($id = null)
    {
        if (!auth()->user()->hasPermission("admin-users-delete")) {
            return $this->dispatch('alert', [
                'type' => 'error',
                'message' => 'You don\'t have permission to delete users.',
            ]);
        }
        $ids = $id ? [$id] : $this->getSelectedRows();
        User::whereIn('id', $ids)->delete();
        $this->clearSelected();
        $this->dispatch('alert', [
            'type' => 'success',
            'message' => $id ? 'User deleted successfully.' : 'Selected User deleted successfully.',
        ]);
    }
}

[lrljoe]

You should not be using

        $this->setAdditionalSelects(['*']); // showable columns

As this defeats the purpose of the filtering that happens for retrieving only the columns necessary for the query.

I'm not able to replicate this, can you confirm the versions:

• Laravel
• Livewire
• The Tables Package
• The theme (e.g. Bootstrap 4/Bootstrap 5/Tailwind 2/Tailwind 3)

And:

• Whether you are bundling or injecting the Tables assets
• Whether you are bundling or injecting the core Livewire assets

Thanks,

Joe.