Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Filter Pills - Ensure Invalid Options Are Removed #2035

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 9, 2024

This change:

  • Ensure that the getAppliedFilters only returns filters that have valid values
  • Splits up the existing filter-pills blade to have three new child blades
    • "Item" (per applied filter)
      • Reset Filter Button (per applied filter)
    • Reset All Button

This also adjusts the class application for key elements in the above blades, in preparation for further improvement.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (0c8ec45) to head (99f3cb3).
Report is 148 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2035      +/-   ##
=================================================
+ Coverage          87.30%   87.76%   +0.45%     
- Complexity          1672     1933     +261     
=================================================
  Files                150      184      +34     
  Lines               3891     4429     +538     
=================================================
+ Hits                3397     3887     +490     
- Misses               494      542      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit c7c97bb into rappasoft:development Nov 9, 2024
9 checks passed
@lrljoe lrljoe mentioned this pull request Nov 10, 2024
lrljoe added a commit that referenced this pull request Nov 10, 2024
## [v3.5.1] - 2024-11-09
### Bug Fixes
- Fix NumberFilter bug for string values by @lrljoe in #2034
- Fixes for Filter Pills - Split blades, and ensure invalid filter alues are removed by @lrljoe in #2035
@lrljoe lrljoe mentioned this pull request Nov 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant