Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io-redis@0.2.0 compatibility fix: roomname format, msgpack format #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashiina
Copy link

@ashiina ashiina commented Dec 29, 2015

Fix for this issue:
https://github.com/rase-/socket.io-php-emitter/issues/20

This is a porting of this commit in the javascript implementation:
socketio/socket.io-redis-emitter@e656600

This fix is necessary to make socket.io-php-emitter work with socket.io-redis version > 0.2.0

@morrislaptop
Copy link

+1 for this to be merged

@nerocrux
Copy link

hope this can be merged

@ismailbaskin
Copy link

@rase- olum merge etsene amk

@jihunleekr
Copy link

@rase- Hello?

@ashiina
Copy link
Author

ashiina commented Jun 3, 2016

As I wrote on https://github.com/rase-/socket.io-php-emitter/issues/20 :

Seems like this repo isn't being maintained for a long time...
Everyone please go ahead and use my fork https://github.com/ashiina/socket.io-php-emitter , on the hotfix/redis-0.2.0-compatibility branch . I will try to maintain it.

Please refer to aPoCoMiLogin 's comment on how to use it via composer.

@ismailbaskin
Copy link

@ashiina you can register your own packagist name. there is no heartbeat on this package

@ashiina
Copy link
Author

ashiina commented Jun 6, 2016

@ismailbaskin Thanks for the tip!

I now added my fork on packagist here
https://packagist.org/packages/ashiina/socket.io-emitter

Please go ahead and use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants