fix: remove html field for TabBar (#978)

* fix: remove `html` field for TabBar & TabHeader * fix: preserve TabHeader html * chore: add changelog * chore: fix typo
raxjs · Feb 24, 2022 · 4622c33 · 4622c33
1 parent a60a201
commit 4622c33
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,16 @@
 ## Changelog
 
+## 3.8.12
+
+- Fix: remove `html` field for TabBar to avoid error in old PHA
+
+## 3.8.11
+
+- Fix: SPA title couldn't specified by route info
+- Fix: store rerender types
+- Fix: url error when build type is Weex
+- Fix: ReDos of postcss
+
 ## 3.8.10
 
 - Fix: manifest.json need includes the scripts which injected by API

diff --git a/packages/plugin-rax-pha/CHANELOG.md b/packages/plugin-rax-pha/CHANELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.0.3
+
+- Fix: remove `html` field for TabBar
+
 ## v2.0.2
 
 - Fix: URL error when build type is Weex

diff --git a/packages/plugin-rax-pha/package.json b/packages/plugin-rax-pha/package.json
@@ -1,6 +1,6 @@
 {
   "name": "build-plugin-rax-pha",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Rax PHA plugins",
   "license": "BSD-3-Clause",
   "main": "lib/index.js",
@@ -20,4 +20,4 @@
   "devDependencies": {
     "webpack": ">=4.0.0"
   }
-}
+}
diff --git a/packages/plugin-rax-pha/src/__tests__/manifestHelper.js b/packages/plugin-rax-pha/src/__tests__/manifestHelper.js
@@ -431,7 +431,6 @@ describe('setRealUrlToManifest', () => {
     expect(manifest.pages[0].tab_header.html).toBeUndefined();
 
     expect(manifest.tab_bar.url).toBe('https://abc.com/customtabbar');
-    expect(manifest.tab_bar.html).toBe('<html>123</html>');
   });
 
   it('should not add script and stylesheet to page', () => {

diff --git a/packages/plugin-rax-pha/src/manifestHelpers.js b/packages/plugin-rax-pha/src/manifestHelpers.js
@@ -214,11 +214,7 @@ function setRealUrlToManifest(options, manifest) {
   }
 
   if (tab_bar && tab_bar.source) {
-    const { document, custom } = applyMethod('rax.getDocument', { name: tab_bar.name, source: tab_bar.source }) || {};
     if (!tab_bar.url) {
-      if (custom) {
-        tab_bar.html = document;
-      }
       // TODO: iOS issue
       // TODO: should remove it in PHA 2.x
       // PHA 1.x should inject `url` to be a base url to load assets

diff --git a/packages/rax-app/package.json b/packages/rax-app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rax-app",
-  "version": "3.8.11",
+  "version": "3.8.12",
   "description": "command line interface and builtin plugin for rax app",
   "author": "Rax Team",
   "homepage": "https://github.com/alibaba/ice#readme",
@@ -21,7 +21,7 @@
     "build-plugin-rax-app": "7.0.7",
     "build-plugin-rax-kraken": "2.1.0",
     "build-plugin-rax-miniapp": "2.0.0",
-    "build-plugin-rax-pha": "2.0.2",
+    "build-plugin-rax-pha": "2.0.3",
     "build-plugin-rax-store": "2.0.1",
     "build-plugin-rax-web": "2.0.7",
     "build-plugin-rax-weex": "2.0.0",