-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Memcached bind #21
Conversation
WalkthroughThe update rectifies a spelling error in the class name from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
Actions PerformedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/MemcachedAdapter.php (1 hunks)
- tests/MemcachedAdapterTest.php (3 hunks)
Additional comments not posted (4)
src/MemcachedAdapter.php (1)
18-18
: Class name corrected toMemcachedAdapter
fromMemcachdAdapter
.tests/MemcachedAdapterTest.php (3)
18-22
: Updated method annotation and instance creation to use the correct class nameMemcachedAdapter
.
37-49
: Updated method annotation and assertions to reflect the correct class nameMemcachedAdapter
.
62-67
: Updated dependency injection configuration to bindAbstractAdapter
toMemcachedAdapter
.
"MemcachdAdapter"もそのまま残しましょう。
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- composer.json (1 hunks)
- src-deprecated/MemcachdAdapter.php (1 hunks)
Files skipped from review due to trivial changes (2)
- composer.json
- src-deprecated/MemcachdAdapter.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src-deprecated/MemcachdAdapter.php (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src-deprecated/MemcachdAdapter.php
Summary by CodeRabbit
MemcachdAdapter
toMemcachedAdapter
for consistency and clarity.composer.json
for the namespaceRay\\PsrCacheModule\\
.MemcachdAdapter
class insrc-deprecated
with a recommendation to use\Ray\PsrCacheModule\MemcachedAdapter
.