Added inference and a way to retrieve the "File Hints" for assistants #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymyers
reviewed
Mar 20, 2024
| @@ -158,3 +158,4 @@ cython_debug/ | |||
| # and can be added to the global gitignore or merged into this file. For a more nuclear | |||
| # option (not recommended) you can uncomment the following to ignore the entire idea folder. | |||
| .idea/ | |||
| checkouts/ | |||
raymyers
reviewed
Mar 20, 2024
| @@ -30,10 +33,9 @@ def upload_file(file_path) -> str | None: | |||
| "rb", | |||
| ), | |||
| purpose="assistants", | |||
| embedding_model="text-embedding-3-large", | |||
There was a problem hiding this comment.
Just curious, does the embedding model default without this?
There was a problem hiding this comment.
I think default is ada-002. We should get scientific and test out a few out including different providers.
|
Good stuff, merging. Fixed a small merge conflict that was due to formatting, in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to create an
assistantand run inference against a row from the benchmark.For #6 to work we needed to be able to get back what files are being used under the hood by Assistants inside a
run. OpenAI's Assistants API has a placeholder for this but they don't use it.From the OpenAI docs:
I implemented this functionality in astra-assitants (v0.1.9) and released it datastax/astra-assistants-api#15
To test just run: