-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BREAKING CHANGE: netcore: scope non-common fields (#47)
1. `domain` => `dnsLookupDomain` 2. `addrs` => `dnsResolvedAddrs` 3. `count` => `ioBufferSize` or `ioBufferCount` This set of changes is part of an overall effort to ensure it's relatively trivial to serialize to a flat data format. To this end, figure out which fields are really common and which fields, instead, are specific, and add prefixes to the specific ones to make it very clear what they are about. Also, avoid overload, and split into two fields when we're using the same field with two distinct semantics dependent on the message type. This should also increase the data format orthogonality. See also rbmk-project/dnscore#13 While there, bump the `rbmk-project/{common,dnscore}` dependencies.
- Loading branch information
1 parent
259541e
commit 83d898f
Showing
4 changed files
with
13 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters