Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis support #8

Merged
merged 10 commits into from
Oct 14, 2024
Merged

Add Redis support #8

merged 10 commits into from
Oct 14, 2024

Conversation

smessie
Copy link
Member

@smessie smessie commented Oct 2, 2024

  • Abstracts away all database specific code to their dedicated repository classe
  • Repository as interface to ease implementation of new databases
  • Add Redis database support

@smessie smessie mentioned this pull request Oct 2, 2024
Merged
@smessie smessie requested a review from ajuvercr October 7, 2024 15:42
ajuvercr
ajuvercr reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@ajuvercr ajuvercr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If more repositories are getting included, I'd want to see something that doesn't work rely on the url scheme

src/repositories/Repository.ts Outdated Show resolved Hide resolved
@ajuvercr ajuvercr merged commit e735dca into master Oct 14, 2024
1 check passed
@ajuvercr ajuvercr deleted the redis branch October 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajuvercr ajuvercr ajuvercr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smessie @ajuvercr