Development/cyclicbuffer #1731
Merged
Development/cyclicbuffer #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (the true) creation of the underlying buffer. Initialization of an already intialized mutex or condition variable may result in undefined behavior. In the context of multiple users one 'creates' and others 'open'. This allows differentiation similar to the contructor taking DataElementFile as argument.
…ition variables are properly initialized before first use.
The typical use case is inter-process, but it allows for multiple threads within a process as gettid() is unique over all processes.
…ond_wait' and 'pthread_cond_timedwait'.
Different workers may be executed from the same underlying pthread.
…to avoid deadlocks.
…ble (underlying) buffer sizes.
Check 'length == 0' only once.
…0c1e9c3cfa' from 'development/cyclicbuffer-deadlock-on-length'.
…14546c50' from 'development/cyclicbuffer-deadlock-on-length'.
Although explicit specification may be preferred, implicit is apparently the accepted use case.
While (looped) waiting on condition variable in 'Sync()' the time out triggers an 'abort()'.
It is unintuitive that the anmount of data is always 1 less than the (maximum) size.
The condition prevents checking an invalid state after construction. Moreover, the invalid state condition is part of the return value, and, identical ASSERTs are used throughout the code where the invalid pointer may be used.
Kept certain 'local' files intact with merge strategy
…buffer_dataexchange'.
…1af07068533d5035e434137863df792cc'
…23'. - Start using the unresponsive detection. - Copy and use the boolean result of the guarded code.
- Added or modified comments. - Only validate reader data if overwrite is disabled.
…testing the effect of 'Reserved' and 'Write'
Make more explicit the effect of 'write', 'reserved' and 'overwrite' with modified data set
…buffer_dataexchange.cpp'.
… and revert 'CyclicBuffer' changes
* Added buildinfo method for QA report * Added public compilesettings * Updated Controller.cpp from seb comments * Updated CMakeLists.txt in core * added priv compilesettings * Added threadcount to buildinfo * Added unused variable macro * systemtype and universal build flags * enum extensions * spelling * empty commit to test action * shortened namespaces and whitespace * extra line --------- Co-authored-by: Pierre Wielders <pierre@wielders.net>
msieben
force-pushed
the
development/cyclicbuffer
branch
from
ebdad80
to
a5a4886
Compare
MFransen69
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.