Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSO search in-process/OOP unification #1761

Merged
merged 3 commits into from
Sep 24, 2024
Merged

DSO search in-process/OOP unification #1761

merged 3 commits into from
Sep 24, 2024

Conversation

sebaszm
Copy link
Contributor

@sebaszm sebaszm commented Sep 23, 2024

Changes:

  • all paths are normalized, rootpath is concatenated properly,
  • linkerpluginpaths are forwarded to ThunderProcess,
  • DSO search order is unified between GetLibrarySearchPaths and ThunderProcess:
  1. if locator is absolute path try [rootpath]/locator
  2. else if linkerpluginpaths are specified, try [rootpath]/linkerpath[i]/locator
  3. else try [rootpath]/datapath/locator, [rootpath]/persistentpath/locator, [rootpath]/systempath/locator, [rootpath]/apppath/Plugins/locator.

Previously 1 was on ThunderProcess only, 2 was on Thunder only, 3 was mutual.

@pwielders pwielders mentioned this pull request Sep 24, 2024
Merged
@pwielders pwielders merged commit 257d635 into master Sep 24, 2024
56 checks passed
@pwielders pwielders deleted the development/so-locator-unification branch September 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwielders pwielders pwielders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebaszm @pwielders