Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proxies by default #1763

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Conversation

nxtum
Copy link
Contributor

@nxtum nxtum commented Sep 24, 2024

Exposes all proxies by default when no id is specified via: Controller.1.proxies

Copy link
Contributor

@sebaszm sebaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about std::vector::insert ?

@sebaszm sebaszm self-requested a review September 24, 2024 11:35
sebaszm
sebaszm previously approved these changes Sep 24, 2024
@pwielders
Copy link
Contributor

@nxtum / @sebaszm there is probably a bit of a bigger story here. Lifetime :-) There was no addref in the past there is no addref now on the list that we passout, but Ithink it is a bit ticky (a larger flaw) The proxies are reference counted but as we pass them out here we do not increase the reference count which could be "scary"... Lets discuss tomorrow in the Sync up call..

@sebaszm
Copy link
Contributor

sebaszm commented Sep 25, 2024

@nxtum / @sebaszm there is probably a bit of a bigger story here. Lifetime :-) There was no addref in the past there is no addref now on the list that we passout, but Ithink it is a bit ticky (a larger flaw) The proxies are reference counted but as we pass them out here we do not increase the reference count which could be "scary"... Lets discuss tomorrow in the Sync up call..

Ah, I didn't consider that.

@sebaszm sebaszm self-requested a review September 25, 2024 13:39
@sebaszm sebaszm merged commit a015de2 into rdkcentral:master Oct 1, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants