SetEnv added for plugin Config as well #1764
Conversation
There was a problem hiding this comment.
See: #1761 which also extends the data flowing to PluginProcess. Prefer to keep it all strong typed (use a C struct or class) and send each element as a seperate (yet repeating) entry on the command line. See inline comments.
I think it is good to also first include thepull request sted above as this might otherswise be difficult to merge (both add functionality in the same areas)
HaseenaSainul
force-pushed
the
development/METROL-606
branch
2 times, most recently
from
193d426
to
b5c2081
Compare
HaseenaSainul
force-pushed
the
development/METROL-606
branch
from
b5c2081
to
bb0c2b1
Compare
HaseenaSainul
force-pushed
the
development/METROL-606
branch
from
7433c7f
to
9cf00eb
Compare
HaseenaSainul
force-pushed
the
development/METROL-606
branch
from
9cf00eb
to
628d5d8
Compare
Source/Thunder/PluginServer.h
Outdated
| Metadata::Service result; | ||
| GetMetadata(result); | ||
| result.ToString(info); | ||
| return (Core::ERROR_NONE); | ||
| } | ||
| std::vector<RPC::Object::Environment> SubstituteList(const std::vector<RPC::Object::Environment>& environments) const { |
There was a problem hiding this comment.
Why do we want to create a "new" list. Can we not just reuse the old list ? It ssaves a lot of memory and if we call this the assumption is that there is no need to "save" the old one..
| } | ||
| return environmentList; | ||
| } | ||
| static RPC::Object::Environment Info(const string& env, RPC::Object::Environment::Scope overriding) |
There was a problem hiding this comment.
This seems to be a parser of a parameter received (env) to an RPC::Object::Environment, why could this not be a constructor of the RPC::Object::Environment class?
Maybe an idea to also creat the string from the parameter there (in the RPC::Object::Environment) as well. A ToStringMethod, that concattenaats the keyand value, and escaped the '" ?
No description provided.