[ProcessContainers] Update Dobby implementation #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goruklu
suggested changes
Oct 10, 2024
| @@ -115,7 +111,7 @@ namespace ProcessContainers { | |||
|
|
|||
| // Dobby stop is async - block until we get the notification the container | |||
| // has actually stopped | |||
| this->InternalLock(); | |||
| // this->InternalLock(); | |||
There was a problem hiding this comment.
can you please remove this line if it's not needed?
There was a problem hiding this comment.
InternalLock() was used to protect the internal list of created containers, which is now handled outside of container provider implementations (since there can be multiple providers). Therefore the InternalLock() method has been removed altogether.
In this context there container list was not modified, so using this lock was not required. But, perhaps, it was reused for a different purpose, so it was only commented out - as a remark, because it may need reviewing whether a critical section is indeed needed here.
I will remove this, since the original purpose of InternalLock is gone.
| @@ -139,7 +135,7 @@ namespace ProcessContainers { | |||
| } | |||
| } | |||
|
|
|||
| this->InternalUnlock(); | |||
| // this->InternalUnlock(); | |||
goruklu
approved these changes
Oct 11, 2024
MFransen69
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.