Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Fixing compilation errors in several examples and adding them to Actions #797

Merged
merged 38 commits into from
Jun 5, 2024

Conversation

VeithMetro
Copy link
Contributor

Here is a JIRA ticket with a list of examples which need a bit more work to make them compile again: https://jira.rdkcentral.com/jira/browse/METROL-972

VeithMetro and others added 25 commits May 23, 2024 11:31
…hunderNanoServices into development/fixing-examples
…hunderNanoServices into development/fixing-examples
…hunderNanoServices into development/fixing-examples
@VeithMetro
Copy link
Contributor Author

It looks like the Windows build is failing, but it has nothing to do with these changes and it is happening for a while due to this error:

D:\a\ThunderNanoServices\ThunderNanoServices\ThunderOnWindows\ThunderClientLibraries\Source\cryptography\Cryptography.vcxproj : error  : Cannot load project with duplicated project items: Module.cpp is included as 'ClCompile' and as 'ClCompile' item types.

@VeithMetro VeithMetro requested a review from pwielders May 28, 2024 13:23
@VeithMetro
Copy link
Contributor Author

Let's first merge this PR (#776) from Marcel like we discussed, and then I'll make slight adjustments to mine

@VeithMetro VeithMetro merged commit d46d41c into master Jun 5, 2024
15 of 19 checks passed
@VeithMetro VeithMetro deleted the development/fixing-examples branch June 5, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants