Contract-to-Contract function calls

[Thomas-Bibby]

I have a the following code on contract A calling contract B:
const result = claimsPoolContract.addFundsInsuranceCover.pay([0, [token1Amt, token1], [0, token2]])(token1Amt * token1Disabled);. ClaimsPoolContract is declared as const claimsPoolContract = remote(claimsPoolctcInfo, C_interface);
I have also tried
const result = claimsPoolContract.addFundsInsuranceCover(amount);
with C_interface being
const C_interface = { roomForInsurance: Fun([UInt], Bool), // View addFundsInsuranceCover: Fun([UInt], UInt), // Function };.
I already can get view data from the claimsPoolContract using roomForInsurance but just can't call addFundsInsurnaceCover. I get an API call failed error in front-end when I run the function.

On Contract B I have a simple function

.api(
        User.addFundsInsuranceCover,
        (amt) => {
        },
        (amt) => [0, [amt, defualtToken], [0, lpToken]],
        (amt, k) => {
          const newTotalFunds = totalFunds + amt;
          const newfundsInsured = fundsInsured + amt;

          k(newTotalFunds);
          return [
            claimsPoolThreshold,
            newfundsInsured,
            lpSupply, 
            newTotalFunds
          ];
        }
      )

I have tested it ensuring the tokens on both contract are the exact same.
The error I get in front-end

[jeapostrophe]

This error says that the function doesn't exist. I bet that User.addFundsInsuranceCover is really named User_addFundsInsuranceCover because you defined User with API('User', C_interface)

[Thomas-Bibby]

I did this and got an error about fees being too low which I then fixed but now I get another error. The only thing I changed was how it was being called, the updated call is as follows const result = claimsPoolContract.User_addFundsInsuranceCover.ALGO({ apps: [ ClaimsCompanion ], fees: 100000 }).pay([0, [toClaimsPool, token1], [0, token2], [0, token3], [0, token4], [0, token5], [0, lpToken]])(toClaimsPool,0,0,0,0);

The error I got was the following:

Error: User.createInsuranceCover errored with Error: API call failed: {
  "type": "signAndPost",
  "e": {
    "status": 400,
    "response": {
      "message": "TransactionPool.Remember: transaction QNTJ56JZYP7EPY3WYGHRN7WT6U5VCHN6VNIWMYNGHCOKEDONYMVQ: logic eval error: logic eval error: assert failed pc=7938. Details: pc=7938, opcodes=global CurrentApplicationAddress\n==\nassert\n. Details: pc=3092, opcodes=load 247\nitxn_field Applications\nitxn_submit\n"
    }
  },
  "es": "Error: Network request error. Received status 400: TransactionPool.Remember: transaction QNTJ56JZYP7EPY3WYGHRN7WT6U5VCHN6VNIWMYNGHCOKEDONYMVQ: logic eval error: logic eval error: assert failed pc=7938. Details: pc=7938, opcodes=global CurrentApplicationAddress\n==\nassert\n. Details: pc=3092, opcodes=load 247\nitxn_field Applications\nitxn_submit\n"
}

I see it says something about CurrentApplicationAddress. Unsure what this means but seems important.

[jeapostrophe]

100000 is way too high for the fees. It should be equal to the number of inner transactions you run. Increment it by 1 until it goes away. That error means the pay amounts are wrong... you're sure they're in the right order? If not it's possible there's a problem on my end.

[Thomas-Bibby]

Awesome I reduced the fees to 1 and that fixes that issue. Yes definitely the Pay statement for the contract being called is

[x,  [x, token1], [x, token2], 
 [x, token3], [x, token4], [x, token5],  [x, lpToken]]

with a payspec of .paySpec([token1, token2, token3, token4, token5, lpToken])

and when calling this contract I use .pay([0, [toClaimsPool, token1], [0, token2], [0, token3], [0, token4], [0, token5], [0, lpToken]])

Now the payspec on both contracts is different as on the contract calling the other its with one less token but I doubt this is an issue.

[jeapostrophe]

Okay, this is a problem with Reach. I've made an issue #1192. You can work around it by (a) changing the caller to not specify 0 in those other tokens, but instead accepting arguments from the API to use in their place OR (b) changing the callee to hard-code 0 at these particular payment sites.

[Thomas-Bibby]

Thanks @jeapostrophe for everything, I can now make contract-to-contract calls. You have been great help.

For anyone who wants to know the end solution here is the code below:
Contract A (Calling Contract B):

  const C_interface = {
    User_addFundsInsuranceCover: Fun([UInt,UInt,UInt,UInt,UInt], UInt), // Create insurance cover
    notRoomForInsurance: Fun([UInt], Bool),
    findOutCompanion: Fun([], Contract)
  };

const claimsPoolContract = remote(claimsPoolctcInfo, C_interface);

const zero = 0;
const result = claimsPoolContract.User_addFundsInsuranceCover.ALGO({ apps: [ ClaimsCompanion ], fees: 1 }).pay([0, [toDAOandClaimsWallet / 2, token1], [zero, token2], [zero, token3], [zero, token4], [0, token5], [0, lpToken]])(toDAOandClaimsWallet,0,0,0,0);

.api(
      User.updateCompanion,
      () => {
        assume(this == owner, "Incorrect caller")
      },
      () => [0, [0, token1], [0, token2], [0, token3], [0, token4], [0, token5]],
      (k) => {
        const claimsPoolContract = remote(claimsPoolctcInfo, C_interface);
        const newClaimsCompanion = claimsPoolContract.findOutCompanion();
        k(newClaimsCompanion)
        return [....  newClaimsCompanion, ....
        ];
      }
    );

This api function updates the companion from getting the view data from Contract B and updating it in the parallel reduce. Call this function as soon as you can.

Contract B (Getting called):

  const User = API("User", {
    addFundsInsuranceCover: Fun([UInt,UInt,UInt,UInt,UInt,UInt], UInt),
  });

.api(
        User.addFundsInsuranceCover,
        (claimableAmount, tok1Amount, tok2Amount, tok3Amount, tok4Amount, tok5Amount) => {
          .......
        },
        (claimableAmount, tok1Amount, tok2Amount, tok3Amount, tok4Amount, tok5Amount) => 
        [0, 
          [tok1Amount, token1], [0, token2], 
          [0, token3], [0, token4], [0, token5], 
          [0, lpToken]],
        (claimableAmount, tok1Amount, tok2Amount, tok3Amount, tok4Amount, tok5Amount, k) => {
          .....

          k(newTotalFunds);
          return [....];
        }
      )