extending array while in parallel-reduce block

[alcyoneus-g]

the idea is voting and in my implementation, I was trying to initially setup empty array of type Address (voters) for yes and no (since we want to allow a single voter to vote only once)
and extend those arrays using concat (since I have read reach array's are fixed size). I am getting the following error currently

reachc: error[RE0088]: These types are mismatched:
  expected: Array(Address, 1)
       got: Array(Address, 0)

  ./index.rsh:123:26:?:

  123|           v === VOTE_YES ? yesVotes.concat(array(Address, [this])) : yesVotes,

Trace:
  in [unknown function] from (./index.rsh:110:19:function exp) at (./index.rsh:110:19:application)

For further explanation of this error, see: https://docs.reach.sh/rsh/errors/#RE0088

CallStack (from HasCallStack):
  expect_throw, called at src/Reach/Eval/Core.hs:366:3 in reach-0.1.11-CbDshw3EQf7JLMU6TWlPrY:Reach.Eval.Core
  expect_, called at src/Reach/Eval/Core.hs:659:5 in reach-0.1.11-CbDshw3EQf7JLMU6TWlPrY:Reach.Eval.Core

And here is a snippet of the current implmentation:

const [keepGoing, hasPassedDeadline,
    yesVotes, noVotes
  ] = parallelReduce([
    true,
    lastConsensusSecs() > end,
    array(Address, []),
    array(Address, []),
  ])
    .invariant(true)
    .define(() => {
      // Vote.endTime.set(endTime);    
    })
    .while(keepGoing)
    .api(
      VoterApi.vote,
      (v) => {
        assume(!hasPassedDeadline, "voting has expired")
        assume(v === VOTE_YES || v === VOTE_NO, "invalid vote")
        assume(yesVotes.indexOf(this) === -1 && noVotes.indexOf(this) === -1, "you already have voted")
      },
      (_) => 0,
      (v, notify) => {
        require(!hasPassedDeadline, "voting has expired")
        require(v === VOTE_YES || v === VOTE_NO, "invalid vote")
        require(yesVotes.includes(this) === -1 && noVotes.indexOf(this) === -1, "you already have voted")
            
        notify(null);
          
        return [
          keepGoing,
          lastConsensusSecs() > end,
          v === VOTE_YES ? yesVotes.concat(array(Address, [this])) : yesVotes,
          v === VOTE_NO ? noVotes.concat(array(Address, [this])) : noVotes,
        ];
      }
    )
    .timeout(false);

thanks

[jeapostrophe]

Variables can only have one type. So you can't change x from Address[5] into Address[6]. I think you could do Maybe<Address>[N]. Or you could use a Map and a count.

[alcyoneus-g]

@jeapostrophe I have tried to use maps to the rescue but still facing some issue in there (same goes for the other one)

For further explanation of this warning, see: https://docs.reach.sh/rsh/errors/#RW0006

reachc: error[RE0085]: Value cannot exist at runtime: <map: map1>

  ./index.rsh:95:21:while

  95|   ] = parallelReduce([

For further explanation of this error, see: https://docs.reach.sh/rsh/errors/#RE0085

CallStack (from HasCallStack):
  expect_throw, called at src/Reach/Eval/Core.hs:366:3 in reach-0.1.11-CbDshw3EQf7JLMU6TWlPrY:Reach.Eval.Core
  expect_, called at src/Reach/Eval/Core.hs:804:16 in reach-0.1.11-CbDshw3EQf7JLMU6TWlPrY:Reach.Eval.Core

and the snippet is

  const yesVotesMap = new Map(Address, UInt)
  const noVotesMap = new Map(Address, UInt)
  
  const [keepGoing, hasPassedDeadline,
    yesVotes, noVotes
  ] = parallelReduce([
    true,
    lastConsensusSecs() > end,
    yesVotesMap,
    noVotesMap,
  ])
    .invariant(true)
    .define(() => {
      // Vote.endTime.set(endTime);    
    })
    .while(keepGoing)
    .api(
      VoterApi.vote,
      (v) => {
        assume(!hasPassedDeadline, "voting has expired")
        assume(v === VOTE_YES || v === VOTE_NO, "invalid vote")
      },
      (_) => 0,
      (v, notify) => {
        require(!hasPassedDeadline, "voting has expired")
        require(v === VOTE_YES || v === VOTE_NO, "invalid vote")

        if (v === VOTE_YES) {
          yesVotes[this] = 1;
        } else {
          noVotes[this] = 1
        }

        notify(null);
        Admin.interact.showVote(this, v, 
          yesVotes.length, noVotes.length
        )
        return [
          keepGoing,
          lastConsensusSecs() > end,
          yesVotes,
          noVotes,
        ];
      }
    )
    .api(
      VoterApi.close,
      (_) => {
        assume(hasPassedDeadline, "endTime has not been reached yet")
      },
      (_) => 0,
      (_, notify) => {
        require(hasPassedDeadline, "endTime has not been reached yet")
        notify(null);        
        return [
          false,
          lastConsensusSecs() > end,
          yesVotes, noVotes
        ];
      }
    )

[jeapostrophe]

You can't (and don't need to) have the maps as part of the parallelReduce values. They are mutable objects, so you just define them before it and use them during it.

[alcyoneus-g]

okay got it @jeapostrophe, but whenever I try to move that to the top, I get the following error:

This Reach application is dangerous to run on Algorand for the following reasons:
 * This program was compiled with trustworthy maps, but maps are not trustworthy on Algorand, because they are represented with local state. A user can delete their local state at any time, by sending a ClearState transaction. The only way to use local state properly on Algorand is to ensure that a user doing this can only 'hurt' themselves and not the entire system.
/stdlib/dist/cjs/ALGO.js:536
        throw Error("This Reach application is not supported on Algorand for the following reasons:\n".concat(render(unsupported)));
              ^

Error: This Reach application is not supported on Algorand for the following reasons:
 * API api_VoterApi_close uses 3225 bytes of logs, but the limit is 1024. API api_VoterApi_close starts at /app/index.rsh:94:21:application.
 * API api_VoterApi_vote uses 3225 bytes of logs, but the limit is 1024. API api_VoterApi_vote starts at /app/index.rsh:94:21:application.
 * Step 0 uses 3232 bytes of logs, but the limit is 1024. Step 0 starts at /app/index.rsh:65:9:dot.
 * Step 1 uses 3208 bytes of logs, but the limit is 1024. Step 1 starts at /app/index.rsh:87:11:dot.
 * Step 3 uses 3225 bytes of logs, but the limit is 1024. Step 3 starts at /app/index.rsh:94:21:dot.
    at must_be_supported (/stdlib/dist/cjs/ALGO.js:536:15)
    at Object.contract (/stdlib/dist/cjs/ALGO.js:1572:13)
    at file:///app/index.mjs:37:29
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

[alcyoneus-g]

and based off the thread I have found on discord, algorand has issues with Maps for storing global data?

[jeapostrophe]

The first thing is a warning. You just need to think about whether it matters.

The second things are errors... you are using too many logs. Generally this means the arguments to functions or events are too big.