Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollParent does not find horizontal scroll parents #16

Open
Siern opened this issue Jan 18, 2017 · 0 comments
Open

scrollParent does not find horizontal scroll parents #16

Siern opened this issue Jan 18, 2017 · 0 comments

Comments

@Siern
Copy link

Siern commented Jan 18, 2017

due to a check of
height(node) < node.scrollHeight

in scrollParent, it will only find vertical scrolling parents.
By function name and description, this is not the behavior I would expect.

I believe it should be || with
width(node) < node.scrollWidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Siern