Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handler do not move when click track and move without mouseup #948

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 2, 2023

图片

点击轨道直接移动鼠标时,滑块不会移动。MUI 则可以:https://mui.com/material-ui/react-slider/

before MUI After
Nov-03-2023 00-16-46 Nov-03-2023 00-16-34 Nov-03-2023 00-16-38

MUI 还有额外有个滑块移动的动画,很顺滑,antd 里后续再补上。

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 4:08am

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@2b92eb4). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head a3cff9a differs from pull request most recent head f1939e0. Consider uploading reports for the commit f1939e0 to get more accurate results

@@            Coverage Diff            @@
##             master     #948   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?       13           
  Lines             ?      551           
  Branches          ?      151           
=========================================
  Hits              ?      550           
  Misses            ?        1           
  Partials          ?        0           
Files Coverage Δ
src/Slider.tsx 100.00% <100.00%> (ø)
src/hooks/useDrag.ts 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@afc163
Copy link
Member Author

afc163 commented Nov 3, 2023

还得补一个用例。

@afc163 afc163 merged commit 9a12e4b into master Nov 3, 2023
8 checks passed
@afc163 afc163 deleted the fix/drag-after-click-track branch November 3, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant