fix: onAfterChange should not trigger when click on track #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoyo837
reviewed
Nov 30, 2023
| @@ -329,7 +329,6 @@ const Slider = React.forwardRef((props: SliderProps, ref: React.Ref<SliderRef>) | |||
|
|
|||
| onBeforeChange?.(getTriggerValue(cloneNextValues)); | |||
| triggerChange(cloneNextValues); | |||
| onAfterChange?.(getTriggerValue(cloneNextValues)); | |||
There was a problem hiding this comment.
为啥 onBeforeChange 可以有， onAfterChange不能？
There was a problem hiding this comment.
onAfterChange 必须对应到 mouseup 事件上，现在允许拖拽之后 change 并不代表一定会触发 afterChange
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| onChangeComplete?.(); | ||
| break; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
=======================================
Coverage 99.81% 99.82%
=======================================
Files 13 13
Lines 551 561 +10
Branches 151 160 +9
=======================================
+ Hits 550 560 +10
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close ant-design/ant-design#46158