add initial TS types detection based on package.json content #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsamp
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
All the changes look good to me. I like where you placed this in the design. Ill wait for @brentvatne to merge this since I'm less familiar with how this might work for a variety of repos.
brentvatne
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Refs #309
This PR introduces the basic check if TypeScript types are published based on the official TS publishing guide. For sure this check is not 100% accurate but I think it's the good start and detection could be improved further. The new search filter has also been added.
In the local tests 307 out of 770 libraries were marked with "TypeScript Types" flag.
The icon, placement and wording could be updated, I'm happy to hear the suggestions.
Additionally to the changes above in this PR I have:
package.jsononly once per libraryLibraryandQueryobjectsPreview
Checklist
If you added a feature or fixed a bug: