Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted CreateHeader Function code #131

Merged

Conversation

ansulagrawal
Copy link
Member

I have reverted the createheader code for fixing the issue in day view.

@ansulagrawal ansulagrawal linked an issue Feb 20, 2024 that may be closed by this pull request
7 tasks
Copy link

codeclimate bot commented Feb 20, 2024

Code Climate has analyzed commit 8ea84ec and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 3

View more on Code Climate.

header = header.add(1, 'weeks').startOf('week');
}
} else if (this.cellUnit === CellUnit.Month) {
while (header >= start && header <= end) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid deeply nested control flow statements.

@ansulagrawal ansulagrawal merged commit f80b0d4 into master Feb 20, 2024
6 of 7 checks passed
@ansulagrawal ansulagrawal deleted the 126-viewtypeday-not-displaying-hour-headers-properly branch February 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewType.Day not displaying hour headers properly
1 participant