Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): translate learn/synchronizing-with-effects into Chinese #1269

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Yucohny
Copy link
Collaborator

@Yucohny Yucohny commented Jul 14, 2023

翻译 learn/synchronizing-with-effects。

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@ZenkieBear ZenkieBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请修复 1 处语义错误👋

ref.current.pause();
}
}, []); // This causes an error
}, []); // 浙江产生错误
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yucohny
“这将”而不是“浙江”。
实时上我正准备认领这篇文章,没想到吃个饭就merge了😂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你如果方便可以提新的 PR 更新翻译~

Copy link
Contributor

@ZenkieBear ZenkieBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些Disconnected,翻译成了“连接失败”,因当为“连接断开”

2. `"❌ Disconnected."`
3. `"✅ Connecting..."`
1. `"✅ 连接中……"`
2. `"❌ 连接失败。"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该翻译为:“断开连接”

},
disconnect() {
console.log('❌ Disconnected.');
console.log('❌ 连接失败。');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处应该翻译为:“断开连接”

},
disconnect() {
console.log('❌ Disconnected.');
console.log('❌ 连接失败。');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处应该翻译为:“断开连接”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以提新的 PR 更新此处翻译~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以提新的 PR 更新此处翻译~

ok~

@Yucohny Yucohny deleted the synchronizing-with-effects branch November 8, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants