fix: page 1부터 시작하도록 변경 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dygma0
approved these changes
Dec 18, 2023
| @@ -116,7 +114,7 @@ public CustomSlice<SimplePerfumeResult> findPerfumesByBrand( | |||
|
|
|||
| @Override | |||
| public CustomPage<SimplePerfumeResult> findPerfumesByCategory( | |||
| Long categoryId, Pageable pageable) { | |||
| Long categoryId, long page, long size) { | |||
There was a problem hiding this comment.
앗 혹시 Pageable을 안쓰시고 분리하신 이유가 있으실까요??
| .limit(pageable.getPageSize()) | ||
| .offset(pageable.getOffset()) | ||
| .limit(size) | ||
| .offset((page - 1) * size) |
There was a problem hiding this comment.
pageable을 안쓰면 이런 조회 쿼리 시 항상 page - 1을 해야한다는 규칙이 추가될 것 같다고 의견을 남기려고 했는데 저도 이렇게 하고 있었군요 ㅋㅋㅋ 이건 수정 해봐도 좋을 것 같은데 어떻게 생각하시나욤?
There was a problem hiding this comment.
아래와 같이 하면 1부터 시작할 수 있다고하는데 적용이 잘 안되어서 일단은 직접 작성했습니다 🥲
@Bean
public PageableHandlerMethodArgumentResolverCustomizer customize() {
return p -> {
p.setOneIndexedParameters(true);
};
}
There was a problem hiding this comment.
다시 pageable으로 돌렸습니다.!!
Comment on lines
15
to
16
| private final long pageNumber; | ||
| private final long size; |
There was a problem hiding this comment.
앗 페이징 범위 내에서 int 범위로도 괜찮을 것 같다는 생각인데 long으로 수정하신 이유가 있을까용? long 타입을 쓰면서 아래 불필요한 형변환이 이뤄지는 것 같아서 의견 남겨요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 👀
Changes ✏️
Test checklist 🧪