향수 통계 정보 조회 API #321
Merged
향수 통계 정보 조회 API #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring of the review statistics reporting has been done to consider only non-deleted reviews. Also, the input parameter type for methods getReviewFeatureCount and findByPerfumeId have been changed to primitive long. Made corresponding changes in the test cases too. Added an EMPTY constant to ReviewFeatureCount.
A new test class, ReviewServiceTest, has been added to the codebase to ensure correct integration and functionality of the review statistics feature. This class includes two main tests: assessing returned statistics when no reviews exist and validating statistics returned for existing reviews. This test will help to maintain the consistency of the Review service, especially during future updates and refactoring.
dygma0
force-pushed
the
task/RDPF-319
branch
from
ebe7eb7
to
cd6f927
Compare
oliviarla
reviewed
Dec 23, 2023
| .leftJoin(userEntity) | ||
| .on(reviewEntity.userId.eq(userEntity.id)) | ||
| .fetchJoin() | ||
| .on(reviewEntity.userId.eq(userEntity.id), userEntity.deletedAt.isNull()) |
There was a problem hiding this comment.
fetchJoin 빼도 괜찮은거였나요?! 😮
on절에 조건도 명시할 수 있었군요..!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 👀
Changes ✏️
Test checklist 🧪