Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Sphinx<5 #220

Merged
merged 23 commits into from
Aug 24, 2023
Merged

Drop support for Sphinx<5 #220

merged 23 commits into from
Aug 24, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 23, 2023 •
edited
Loading

I'm matching the plan with sphinx_rtd_theme to reduce maintainers work: readthedocs/sphinx_rtd_theme#1500

Closes #217
Closes #219
Closes #216

@humitos
Drop support for Sphinx<5
ad60c8d 
I'm matching the plan with `sphinx_rtd_theme` to reduce maintainers work.
@humitos humitos requested a review from a team as a code owner August 23, 2023 14:08
ericholscher
ericholscher approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We should update the setup.py with this change as well, I think?

@AA-Turner
Copy link
Contributor

AA-Turner commented Aug 24, 2023 •
edited
Loading

@humitos Please consider cherry-picking the two commits on this branch: https://github.com/AA-Turner/sphinx-notfound-page/tree/humitos/drop-support-old-versions to this PR

  • Updated CircleCI configuration
  • Updated pyproject.toml
  • Declared support for Python 3.8--3.12
  • Dropped sphinx-prompt due to version incompatability (Sphinx 4+ blocks selection of the prompt by default regardless)
  • Removed dead test code
  • Re-compiled docs deps
  • Fixed a conf.py error (language = None)
  • Updated patching of pathto and toctree

A

@humitos humitos requested a review from a team as a code owner August 24, 2023 10:02
@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

When all tests pass, I will do a 1.0.0rc with all these changes 🎉

@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

This looks good. We should update the setup.py with this change as well, I think?

Good point. We are using pyproject.toml in this repository and AA-Turner already updated 👍🏼

@humitos humitos merged commit dcb3adc into main Aug 24, 2023
@humitos humitos deleted the humitos/drop-support-old-versions branch August 24, 2023 13:35
@befeleme befeleme mentioned this pull request Aug 24, 2023
Closed
@humitos
Copy link
Member Author

humitos commented Aug 24, 2023

I released https://pypi.org/project/sphinx-notfound-page/1.0.0rc1/, please give it a try and let me know if it works fine for your use case.

@AA-Turner
Copy link
Contributor

Thanks @humitos! All seems well

A

@namurphy
Copy link

Just tried v1.0.0rc1 for our repository too, and all is looking good! Thank you for getting this done so quickly!

@humitos
Copy link
Member Author

humitos commented Aug 30, 2023

I released v1.0.0. I hope it works for everybody 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@humitos @AA-Turner @namurphy @ericholscher