re-exec a query if items were removed from the persistent results #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanH
commented
Dec 4, 2023
| @@ -1834,7 +1834,7 @@ describe('rx-query.test.ts', () => { | |||
| collection.database.destroy(); | |||
| }); | |||
|
|
|||
| it.skip('gives correct limit results when items were removed', async () => { | |||
| it('gives correct limit results when items were removed', async () => { | |||
There was a problem hiding this comment.
this test passes now (fails on readwise)
eliias
approved these changes
Dec 5, 2023
eliias
force-pushed
the
tristan/persistence-improvments
branch
from
6020302
to
249ec1a
Compare
eliias
force-pushed
the
tristan/fix-persistent-limit-buffer-case
branch
from
a7b67a9
to
2df803b
Compare
TristanH
merged commit a958b6a
into
tristan/persistence-improvments
13 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the only way to be confident about our results. i think there's a chance the restore function could move stuff around to not do the (somewhat expensive) lwt query until we know nothing has been removed, but might not be worth it.