Persist limit buffers #14

TristanH · 2023-12-07T06:06:02Z

Still needs:

Tests
Performance improvements (eg add ids to existing persisted qc key instead of adding new row)

Other than the above, i think this is good to go! 🤞

…handle all edge cases

src/rx-query.ts

…correct) the restoration logic. and more tests for it.

… the persistent ids

persist limit buffers mvp

20da204

TristanH requested a review from eliias December 7, 2023 06:06

Base automatically changed from tristan/remove-persisted-counts to readwise December 7, 2023 20:47

TristanH added 2 commits December 8, 2023 02:51

add tests for persisted limit buffer, and improve the logic a lot to …

0473da0

…handle all edge cases

remove .only from tests

9fc54f3

TristanH changed the title ~~persist limit buffers proof of concept~~ Persist limit buffers Dec 8, 2023

TristanH added 2 commits December 8, 2023 03:39

add yet another edge case test and catch it in the logic

2ab2bdb

catch another edge case

058e9c0

TristanH force-pushed the tristan/persist-limit-buffer branch from 14ab90a to 058e9c0 Compare December 8, 2023 09:20

mitchelljustin reviewed Dec 8, 2023

View reviewed changes

src/rx-query.ts Outdated Show resolved Hide resolved

TristanH added 6 commits December 9, 2023 20:42

move check for querycache is array up a level, simplifying

4d0b936

serious refactor to dramatically simplify (and make more efficient + …

e7f46f6

…correct) the restoration logic. and more tests for it.

stop re-persisting when limit results are removed

608adc0

remove leftover count logic we no longer use

bcfec8b

remove a cache read+write for each query by storing limit buffer with…

efb9c9f

… the persistent ids

fix the cache size checks in tests now that we're down to 2 keys

17822a4

TristanH merged commit a4647e0 into readwise Dec 10, 2023
19 of 21 checks passed

Provide feedback