Improvements to persistent query cache from testing (RW-34462) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanH
force-pushed
the
tristan/persistence-improvments
branch
2 times, most recently
from
99c2926
to
0c3d9d8
Compare
eliias
reviewed
Dec 3, 2023
| @@ -521,6 +521,10 @@ export class RxQueryBase< | |||
| } | |||
|
|
|||
| enablePersistentQueryCache(backend: QueryCacheBackend) { | |||
| if (this._persistentQueryCacheBackend) { | |||
There was a problem hiding this comment.
Oh… this happened when a component re-rendered I assume?
There was a problem hiding this comment.
yeah i'm not fully sure yet, something like that
TristanH
changed the title
eliias
force-pushed
the
tristan/persistence-improvments
branch
from
6020302
to
249ec1a
Compare
…uffer-case re-exec a query if items were removed from the persistent results
|
@eliias tests are still failing on this branch even though it has your fix 🤔 |
TristanH
force-pushed
the
tristan/persistence-improvments
branch
from
6f2d9ec
to
372ba29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Also see: https://github.com/readwiseio/rekindled/pull/3391