Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paperclip-vips to use kt-paperclip #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

toddwsullivan
Copy link

With the main paperclip branch being deprecated and unsupported, I think it would be beneficial to have paperclip-vips migrate to using the supported branch, kt-paperclip.

@kengreeff
Copy link
Contributor

We have looked at swapping this over but unfortunately we have a lot of other dependencies that rely on the original gem file.

Are you using this gem in production @todd-tsu ?

Copy link
Contributor

@kengreeff kengreeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also need to bump the version, probably a major as it changes the main dependency

@@ -7,7 +7,7 @@ A custom paperclip processor that uses the [libvips image processing library](ht
Add this line to your application's Gemfile:

```ruby
gem 'paperclip-vips'
gem 'paperclip-vips', :git=>'https://github.com/tsu-social/paperclip-vips.git'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't need this if merging

@toddwsullivan
Copy link
Author

We have looked at swapping this over but unfortunately we have a lot of other dependencies that rely on the original gem file.

With paperclip deprecated, we quickly moved to kt-paperclip. I'm happy to create a new gem entirely for this that can pull from any changes if you think that's a better way to go, like kt-paperclip-vips.

Are you using this gem in production @todd-tsu ?

Not yet. We are evaluating it for production use though. If we end up not using it, I wouldn't be the right choice to maintain any upstream changes though.

@kengreeff
Copy link
Contributor

kengreeff commented Feb 8, 2021

@todd-tsu I think it makes sense to fork this and run with kt-paperclip-vips, so it is clear it relies on kt-paperclip.

If you are still evaluating image libraries I highly recommend giving shrine a go - it is great and we are using it in our new projects. It is super customizable and has vips support out of the box.

https://github.com/shrinerb/shrine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants