bug fixes

realiti4 · Nov 15, 2023 · e63efd4 · e63efd4
1 parent b28d2d4
commit e63efd4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setup(
     name="tradingfeatures",
-    version="0.7.0",
+    version="0.7.1",
     author="Onur Cetinkol",
     author_email="realiti44@gmail.com",
     description="A useful tool to download market history from popular exchanges.",

diff --git a/tradingfeatures/api_base.py b/tradingfeatures/api_base.py
@@ -124,11 +124,11 @@ def get_hist(
                     end=str(end_batch),
                 )
                 if df_temp is None:  # Try this fix for other apis
-                    print("    Warning: Got empty window from exchange at start")
+                    df_temp = pd.DataFrame()
                     assert (
                         len(df) == 0
                     ), "Warning: Got empty window from exchange in middle of download"
-                    df_temp = pd.DataFrame()
+                    print("    Warning: Got empty window from exchange at start")
             except Exception as e:
                 # raise e
                 print(e, "\nDebug: error between timestamps: ", start_batch, end_batch)
@@ -196,7 +196,7 @@ def calc_start(self, limit, start=None, end=None, interval=3600, scale=1):
         end = current_time if end is None else end
         if start is None:
             start = end - (
-                interval * (limit - 1)
+                (interval * limit) - 3600
             )  # limit -1 to be sure to get the latest hour
         out_of_range = True if limit > self.limit else False
         return start, end, out_of_range

diff --git a/tradingfeatures/apis/binance/funding.py b/tradingfeatures/apis/binance/funding.py
@@ -62,15 +62,15 @@ def get(
 
         df = pd.DataFrame(result)
         df["timestamp"] = df["fundingTime"].div(1000).astype(int)
-        df.pop("fundingTime")
-        df.pop("symbol")
+        df = df[['fundingRate', 'timestamp']]
         df = df.set_index("timestamp")
-        df = df.astype(float)
         df.rename(columns={"fundingRate": "fundingRate_binance"}, inplace=True)
 
         if get_latest:  # add this to binance as well
             df = self.get_recent(df)
 
+        df = df.astype(float)
+
         # if columns is not None:
         #     return df[columns]
         return self.convert_funding(df, get_latest)