Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Dialog and Alert Dialog #2

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Feature: Dialog and Alert Dialog #2

merged 9 commits into from
Nov 9, 2023

Conversation

jorenrui
Copy link
Contributor

@jorenrui jorenrui commented Nov 9, 2023 •
edited by github-actions bot
Loading

Description

  • Rename array methods: previousOf and nextOf to nextItem and previousItem.
  • Add dialog and alert dialog examples.
  • Update the Lexer to:
    • Detect decimal and methods on numbers
    • Detect spread operator
    • Detect escaped string terminators (', ", and backtick)
    • Detect object keys

Next Steps

Might replace the current tokenizer with js-tokens

📦 Published PR as canary version: 1.0.2-canary.2.b55e1ca.0

✨ Test out this PR locally via:

npm install tonic-minijs@1.0.2-canary.2.b55e1ca.0
# or 
yarn add tonic-minijs@1.0.2-canary.2.b55e1ca.0

@jorenrui jorenrui self-assigned this Nov 9, 2023
@jorenrui jorenrui merged commit b55e1ca into main Nov 9, 2023
1 check passed
@jorenrui jorenrui deleted the jr.feat-dialogs branch November 9, 2023 11:05
@github-actions GitHub Actions
Copy link

🚀 PR was released in v1.0.1 🚀

@github-actions github-actions bot added the released This has been released in npm label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jorenrui jorenrui

Labels
released This has been released in npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jorenrui