Refactor: Lexer Variables #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor!: change lexer to use acorn and codegen instead of js-tokens. Realized that creating our own AST reader is a huge task, make take a lot of time and prone for errors if we want to be spec compliant. With this, I decided to use acorn and codegen instead in terms of identifying variables. - fix: non-MiniJS variables are being read by Mini.js. I made so that we are not automatically reading user defined global variables. We now only fetch variables from attributes and events. Currently, we can't fetch from the scripts since we are not sure whether that script is defined by a user or a library. - fix: not being able to declare variables due to being read as a proxy variable.
This was referenced Dec 17, 2023
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the lexer to use acorn and codegen in updating the identifiers
📦 Published PR as canary version:
1.0.1-canary.5.ab7dcf5.0✨ Test out this PR locally via:
npm install tonic-minijs@1.0.1-canary.5.ab7dcf5.0 # or yarn add tonic-minijs@1.0.1-canary.5.ab7dcf5.0