Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential outgoing message corruption in managed websockets #3671

Closed
sync-by-unito bot opened this issue Sep 16, 2024 · 1 comment · Fixed by #3670
Closed

Potential outgoing message corruption in managed websockets #3671

sync-by-unito bot opened this issue Sep 16, 2024 · 1 comment · Fixed by #3670
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Sep 16, 2024

When managed websockets are enabled we use array pooling to cut down on constant managed heap allocations for the byte arrays that store the sync messages Core wants us to send. However there is a chance that if a rented array is bigger than the buffer we need to store we will attempt to send the entire array, including stale data it contained previously.

Copy link
Author

sync-by-unito bot commented Sep 16, 2024

➤ PM Bot commented:

Jira ticket: RNET-1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant