Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new documentation URL #3568

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Update to new documentation URL #3568

merged 4 commits into from
Apr 22, 2024

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Apr 8, 2024

Description

Fixes #

TODO

  • Changelog entry
  • Tests

@kneth kneth added no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference labels Apr 8, 2024
@kneth kneth self-assigned this Apr 8, 2024
@kneth kneth requested a review from papafe April 8, 2024 10:29
@cla-bot cla-bot bot added the cla: yes label Apr 8, 2024
@kneth kneth requested a review from nirinchev April 8, 2024 10:29
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Congratulation on your first contribution 😁

Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of API docs that also need to be updated. If you grep for docs.mongodb.com you can find those.

@kneth kneth requested review from papafe and nirinchev April 10, 2024 08:52
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments

Realm/Realm/Exceptions/Sync/ErrorCode.cs Outdated Show resolved Hide resolved
Docs/index.md Outdated Show resolved Hide resolved
Copy link

coveralls-official bot commented Apr 10, 2024

Pull Request Test Coverage Report for Build 8755920508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 81.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Helpers/AsyncHelper.cs 0 1 0.0%
Realm/Realm/Schema/ObjectSchema.cs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Handles/AppHandle.cs 8 94.89%
Totals Coverage Status
Change from base Build 8598129525: -0.005%
Covered Lines: 6788
Relevant Lines: 8230

💛 - Coveralls

@kneth kneth requested a review from papafe April 12, 2024 07:44
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one comment, I think it's ready to merge

Realm/Realm/Exceptions/Sync/ErrorCode.cs Outdated Show resolved Hide resolved
Co-authored-by: Ferdinando Papale <4850119+papafe@users.noreply.github.com>
@kneth kneth merged commit d73f9e5 into main Apr 22, 2024
80 of 81 checks passed
@kneth kneth deleted the kneth/new-docs-url branch April 22, 2024 14:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants