RNET-1132: Add tests for sync schema migration #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8629196354Details
💛 - Coveralls |
papafe
reviewed
Apr 10, 2024
| @@ -473,9 +475,9 @@ private async Task<BaasApp> CreateFlxApp(string name) | |||
| { | |||
| state = "enabled", | |||
| database_name = GetSyncDatabaseName(name), | |||
| queryable_fields_names = new[] { "Int64Property", "GuidProperty", "DoubleProperty", "Int", "Guid", "Id", "PartitionLike" }, | |||
| queryable_fields_names = new[] { "Int64Property", "GuidProperty", "DoubleProperty", "Int", "Guid", "Id", "PartitionLike", "Differentiator" }, | |||
There was a problem hiding this comment.
Not a biggie, but maybe we should find another name for "differentiator"? We already use it for differentiating the apps, maybe it could create confusion
There was a problem hiding this comment.
I feel it's a reasonable name given that it differentiates things based on some criteria. Is it the best name - probably not, but I liked it better than PartitionLike 😄
papafe
reviewed
Apr 10, 2024
nielsenko
approved these changes
Apr 12, 2024
| @@ -473,9 +475,9 @@ private async Task<BaasApp> CreateFlxApp(string name) | |||
| { | |||
| state = "enabled", | |||
| database_name = GetSyncDatabaseName(name), | |||
| queryable_fields_names = new[] { "Int64Property", "GuidProperty", "DoubleProperty", "Int", "Guid", "Id", "PartitionLike" }, | |||
| queryable_fields_names = new[] { "Int64Property", "GuidProperty", "DoubleProperty", "Int", "Guid", "Id", "PartitionLike", "Differentiator" }, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3569