RNET-1133: Fixed equality comparison for collections in mixed #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8706976682Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
rorbech
reviewed
Apr 16, 2024
nielsenko
reviewed
Apr 16, 2024
Comment on lines
+1536
to
+1537
| RealmValueType.List => AsList().Equals(other.AsList()), | ||
| RealmValueType.Dictionary => AsDictionary().Equals(other.AsDictionary()), |
Comment on lines
103
to
113
| "string", | ||
| new byte[] { 0, 1, 2 }, | ||
| new DateTimeOffset(1234, 5, 6, 7, 8, 9, TimeSpan.Zero), | ||
| 1f, | ||
| 2d, | ||
| 3m, | ||
| new ObjectId("5f63e882536de46d71877979"), | ||
| Guid.Parse("3809d6d9-7618-4b3d-8044-2aa35fd02f31"), | ||
| new InternalObject { IntProperty = 10, StringProperty = "brown" }, | ||
| innerList, | ||
| innerDict, |
There was a problem hiding this comment.
I could have kept the full list, but in the end it shouldn't make a difference on the test and I thought it would make the test easier to read. I didn't really need to 😁
There was a problem hiding this comment.
Okay.. gut reaction was just that the coverage was diminished, and would those tests now have failed?
There was a problem hiding this comment.
That's understandable, I'll put those back so it's easier to follow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3572