Update to latest Core #3585
Merged
Update to latest Core #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
added
no-changelog
Pull Request Test Coverage Report for Build 8849535744Details
💛 - Coveralls |
papafe
approved these changes
Apr 26, 2024
| @@ -7,7 +7,7 @@ name: test-ios | |||
| _: #@ template.replace(testDefinition()) | |||
| jobs: | |||
| test-xamarin: | |||
| runs-on: macos-latest | |||
| runs-on: macos-12 | |||
There was a problem hiding this comment.
Shouldn't we this and the others to 13?
There was a problem hiding this comment.
13 doesn't have the xamarin tooling. We could manually install it, but I'd rather just use 12 while possible and then either deprecate Xamarin or add a step to manually install at that point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GHA workflow changes are related to macos-14 recently becoming macos-latest, which broke our assumptions about the architecture.
This depends on realm/realm-core#7632 - once it's merged, we should retarget master.
TODO