Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to .net 8 #3586

Merged
merged 21 commits into from
Apr 30, 2024
Merged

Update to .net 8 #3586

merged 21 commits into from
Apr 30, 2024

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Apr 25, 2024 •
edited
Loading

Description

Fixes #

TODO

  • Changelog entry
  • Tests

@cla-bot cla-bot bot added the cla: yes label Apr 25, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8880222369

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 80.113%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Helpers/SerializationHelper.cs 1 53.16%
Totals Coverage Status
Change from base Build 8850723786: 0.01%
Covered Lines: 6713
Relevant Lines: 8231
💛 - Coveralls

Base automatically changed from ni/new-core-2 to main April 26, 2024 15:34
@nirinchev nirinchev requested a review from papafe April 29, 2024 12:50
@nirinchev nirinchev marked this pull request as ready for review April 29, 2024 12:50
@nirinchev nirinchev added the no-jira-ticket Skip checking the PR title for Jira reference label Apr 29, 2024
papafe
papafe approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some small warnings it looks good

Realm/Realm.PlatformHelpers/Realm.PlatformHelpers.csproj
@@ -10,7 +10,7 @@
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<!-- Mono MSBuild (16.0) on macOS cannot target .NET 6 so we can only add the .NET 6 tfms for dotnet build/Windows MSBuild -->
<TargetFrameworks Condition="($([MSBuild]::IsOsPlatform('Windows')) AND '$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture)' == 'X64') OR ($([MSBuild]::IsOsPlatform('macOS')) AND '$(MSBuildVersion)' &gt;= '17.0')">
$(TargetFrameworks);net6.0-ios;net6.0-android;net6.0-maccatalyst;net6.0-tvos
$(TargetFrameworks);net7.0-ios;net7.0-android;net7.0-maccatalyst;net7.0-tvos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we don't use .net 8 here?

@nirinchev nirinchev merged commit 66f54a1 into main Apr 30, 2024
65 of 66 checks passed
@nirinchev nirinchev deleted the ni/baas-change-url branch April 30, 2024 13:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @papafe