Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNET-1109: Add App.UpdateBaseUri #3587

Merged
merged 4 commits into from
Apr 30, 2024
Merged

RNET-1109: Add App.UpdateBaseUri #3587

merged 4 commits into from
Apr 30, 2024

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Apr 29, 2024 •
edited
Loading

Description

Fixes #3521

TODO

  • Changelog entry
  • Tests

@cla-bot cla-bot bot added the cla: yes label Apr 29, 2024
@nirinchev nirinchev requested a review from papafe April 29, 2024 23:58
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8887026193

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.137%
Totals Coverage Status
Change from base Build 8880222369: 0.02%
Covered Lines: 6724
Relevant Lines: 8241
💛 - Coveralls

papafe
papafe approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I suppose it just needs the changelog

Base automatically changed from ni/baas-change-url to main April 30, 2024 13:12
@nirinchev nirinchev merged commit 221d4c3 into main Apr 30, 2024
65 of 67 checks passed
@nirinchev nirinchev deleted the ni/base-uri-2 branch April 30, 2024 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

@dianaafanador3 dianaafanador3 Awaiting requested review from dianaafanador3

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baseUrl Change
2 participants
@nirinchev @papafe