Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Hide collections in mixed from public API" #3606

Merged
merged 5 commits into from
May 21, 2024
Merged

Revert "Hide collections in mixed from public API" #3606

merged 5 commits into from
May 21, 2024

Conversation

nirinchev
Copy link
Member

Reverts #3575

@cla-bot cla-bot bot added the cla: yes label May 21, 2024
@nirinchev nirinchev changed the base branch from main to ni/core-14.7.0 May 21, 2024 21:06
@nirinchev nirinchev added the no-jira-ticket Skip checking the PR title for Jira reference label May 21, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9181487332

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 81.27%
Totals Coverage Status
Change from base Build 9181348366: 1.1%
Covered Lines: 6831
Relevant Lines: 8261
💛 - Coveralls

Base automatically changed from ni/core-14.7.0 to main May 21, 2024 22:05
@nirinchev
Copy link
Member Author

Failing tests are due to a change in schema migrations on the server. I've asked here: https://mongodb.slack.com/archives/C04NACGT7J7/p1716329105823099.

@nirinchev nirinchev marked this pull request as ready for review May 21, 2024 22:06
@nirinchev nirinchev merged commit 1298cb1 into main May 21, 2024
83 of 85 checks passed
@nirinchev nirinchev deleted the revert-3575-fp/hide-mixed-collection branch May 21, 2024 22:06
nirinchev added a commit that referenced this pull request May 22, 2024
@nirinchev
Merge branch 'main' into ni/pkl
895ecc1 
* main:
  RNET-1134: Add obfuscation attribute on generated RealmSchema (#3594)
  Revert "Hide collections in mixed from public API" (#3606)
  Update to Core 14.7.0 (#3605)
  RNET-1145, RNET-1143: Fix reading schema from native (#3601)

# Conflicts:
#	.github/templates/test-weaver.yml
#	.github/workflows/test-weaver.yml
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nirinchev nirinchev

Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nirinchev