RNET-1137: Fix progress notification #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nirinchev I've added a basic test, not sure how extensive we want to be with testing for this. |
nirinchev
reviewed
Jun 3, 2024
| @@ -828,25 +837,18 @@ public void Session_OnSessionError() | |||
| } | |||
|
|
|||
| completionTcs.TrySetResult(); | |||
| lastReportedProgress = p.ProgressEstimate; | |||
There was a problem hiding this comment.
Why is this happening after we complete the tcs?
There was a problem hiding this comment.
It shouldn't, it should happen all the time, I'll fix it 🤦
nirinchev
approved these changes
Jun 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the correct core value for the progress notification, and adds some basic tests
Fixes #3580
TODO