Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNET-1155: Add more validation to .Filter arguments #3620

Merged
merged 3 commits into from
Jun 21, 2024
Merged

RNET-1155: Add more validation to .Filter arguments #3620

merged 3 commits into from
Jun 21, 2024

Conversation

nirinchev
Copy link
Member

Description

Fixes #3619

TODO

  • Changelog entry
  • Tests

@cla-bot cla-bot bot added the cla: yes label Jun 6, 2024
@nirinchev nirinchev requested a review from papafe June 6, 2024 08:44
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9397855210

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.28%
Totals Coverage Status
Change from base Build 9396954693: 0.01%
Covered Lines: 6835
Relevant Lines: 8265
💛 - Coveralls

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9483254215

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.271%
Totals Coverage Status
Change from base Build 9482362848: 0.01%
Covered Lines: 6834
Relevant Lines: 8265
💛 - Coveralls

@nirinchev nirinchev merged commit be05efc into main Jun 21, 2024
58 of 62 checks passed
@nirinchev nirinchev deleted the ni/filter-argument-validation branch June 21, 2024 15:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection.Filter should error out if argument is a removed object
2 participants
@nirinchev @papafe