Add flexible schema mapping POC #3635
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9681982895Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9742975006Details
💛 - Coveralls |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+601
to
+612
| if (getValueLines.Length == 0) | ||
| { | ||
| getValueBody = @"throw new MissingMemberException($""The object does not have a gettable Realm property with name {propertyName}"");"; | ||
| } | ||
| else | ||
| { | ||
| getValueBody = $@"return propertyName switch | ||
| {{ | ||
| {getValueLines.Indent(trimNewLines: true)} | ||
| _ => throw new MissingMemberException($""The object does not have a gettable Realm property with name {{propertyName}}""), | ||
| }};"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+617
to
+629
| if (setValueLines.Length == 0) | ||
| { | ||
| setValueBody = @"throw new MissingMemberException($""The object does not have a settable Realm property with name {propertyName}"");"; | ||
| } | ||
| else | ||
| { | ||
| setValueBody = $@"switch (propertyName) | ||
| {{ | ||
| {setValueLines.Indent(trimNewLines: true)} | ||
| default: | ||
| throw new MissingMemberException($""The object does not have a settable Realm property with name {{propertyName}}""); | ||
| }}"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+640
to
+651
| if (getListValueLines.Length == 0) | ||
| { | ||
| getListValueBody = @"throw new MissingMemberException($""The object does not have a Realm list property with name {propertyName}"");"; | ||
| } | ||
| else | ||
| { | ||
| getListValueBody = $@"return propertyName switch | ||
| {{ | ||
| {getListValueLines.Indent(trimNewLines: true)} | ||
| _ => throw new MissingMemberException($""The object does not have a Realm list property with name {{propertyName}}""), | ||
| }};"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+656
to
+667
| if (getSetValueLines.Length == 0) | ||
| { | ||
| getSetValueBody = @"throw new MissingMemberException($""The object does not have a Realm set property with name {propertyName}"");"; | ||
| } | ||
| else | ||
| { | ||
| getSetValueBody = $@"return propertyName switch | ||
| {{ | ||
| {getSetValueLines.Indent(trimNewLines: true)} | ||
| _ => throw new MissingMemberException($""The object does not have a Realm set property with name {{propertyName}}""), | ||
| }};"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+672
to
+683
| if (getDictionaryValueLines.Length == 0) | ||
| { | ||
| getDictionaryValueBody = @"throw new MissingMemberException($""The object does not have a Realm dictionary property with name {propertyName}"");"; | ||
| } | ||
| else | ||
| { | ||
| getDictionaryValueBody = $@"return propertyName switch | ||
| {{ | ||
| {getDictionaryValueLines.Indent(trimNewLines: true)} | ||
| _ => throw new MissingMemberException($""The object does not have a Realm dictionary property with name {{propertyName}}""), | ||
| }};"; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+746
to
+759
| if (property.TypeInfo.IsBacklink) | ||
| { | ||
| getFieldString = "GetBacklinks"; | ||
| } | ||
| else | ||
| { | ||
| getFieldString = property.TypeInfo.CollectionType switch | ||
| { | ||
| CollectionType.List => "GetListValue", | ||
| CollectionType.Set => "GetSetValue", | ||
| CollectionType.Dictionary => "GetDictionaryValue", | ||
| _ => throw new NotImplementedException(), | ||
| }; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Pull Request Test Coverage Report for Build 9875518284Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes doc
TODO:
Must-have
Nice to have