Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Claus Rørbech <claus.rorbech@mongodb.com>
  • Loading branch information
clementetb and rorbech authored Aug 1, 2023
1 parent c6b6aaa commit 5fcec27
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions AppServicesUsageSamples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ This demo shows the process of protecting users' sensitive data by employing end

The project has been structured in two main folders:

- Demo - Android app containing the different samples. Samples have been separated in different packages.
- Apps - Atlas App services apps required by each sample.
- `demo` - Android app containing the different samples. Samples have been separated in different packages.
- `apps` - Atlas App services apps required by each sample.

## Getting started

The demos are indendepent of each other, this means that it is not required to install all the app services app samples to test an individual sample.
The demos are indendepent of each other, which means that it is not required to install all the app services app samples to test an individual sample.

To begin, locate the App services app sources that you wish to install. We have conveniently linked them in the Samples list of this document.
To get started, locate the App services app sources in `apps` that you wish to install. We have conveniently linked them in the Samples list of this document.

Next, follow the steps outlined in the [Atlas documentation](https://www.mongodb.com/docs/atlas/app-services/apps/create/) to setup the apps. These docs will guide you through the process and help troubleshoot any issue you might encounter.

Expand Down
2 changes: 1 addition & 1 deletion AppServicesUsageSamples/apps/property-encryption/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class Person: RealmObject {

Currently, there are some limitations on how we can associate a key to an object or property because RealmObjects don't provide any information about its source realm or user yet. In this demo we have opted for storing such data in global variables.

![alt text](diagram3.svg "Flow")
![alt text](diagram2.svg "Flow")

## Vectors attacks
Nothing is 100% secure, there is always a tradeoffs associated with security. The implementation outlined here also suffers from the vulnerabilities. Please evaluate them against your security needs before using the approach outlined:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
import org.koin.compose.koinInject

/**
* This screens prompts the user to wheter register or authenticate via email-password.
* This screens prompts the user to register or authenticate via email-password.
*/
@Composable
fun LoginScreen(
Expand Down

0 comments on commit 5fcec27

Please sign in to comment.