Disable creating contracts with invalid spans

realsuayip · Jan 19, 2024 · fced377 · fced377
1 parent 6bbf077
commit fced377
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/pcontract/data.py b/pcontract/data.py
@@ -117,6 +117,8 @@ def init(
         meta: dict[str, Any] | None = None,
     ) -> Contract:
         initial_branch = Branch(start_at=start_at, end_at=end_at, data=data)
+        if (not initial_branch.span) or (zero > initial_branch.span):
+            raise ValueError("%s spans nothing." % initial_branch)
         return cls(items=[initial_branch], meta=meta)
 
     def branch(

diff --git a/tests.py b/tests.py
@@ -226,3 +226,18 @@ def test_dataref(self):
         self.assertEqual({"_ref": m1.uuid}, r2.data)
 
         self.assertEqual({"key": "mars"}, m3.data)
+
+    def test_contract_init_spans_nothing(self):
+        with self.assertRaisesRegex(ValueError, r".spans nothing"):
+            Contract.init(
+                start_at=self.start,
+                end_at=self.start,
+                data={"key": "venus"},
+            )
+
+        with self.assertRaisesRegex(ValueError, r".spans nothing"):
+            Contract.init(
+                start_at=self.start,
+                end_at=self.start - datetime.timedelta(days=1),
+                data={"key": "venus"},
+            )