6 api client creation #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
okraskaj
force-pushed
the
6-api-client-creation
branch
9 times, most recently
from
6af0097 to
e903460
Compare
okraskaj
force-pushed
the
6-api-client-creation
branch
5 times, most recently
from
9febc89 to
b907da2
Compare
diegodelemos
force-pushed
the
6-api-client-creation
branch
from
b907da2 to
45563e0
Compare
diegodelemos
force-pushed
the
6-api-client-creation
branch
from
45563e0 to
61ee140
Compare
diegodelemos
force-pushed
the
6-api-client-creation
branch
from
61ee140 to
27d9025
Compare
* Introduces single variable local proxy instead of decorator- before we depended on the with_api_client decorator, and the click context- now it's only one LocalProxy. * Removes Client class because it was using inheritance (from BaseAPIClient) and it wasn't a correct relation. Without it it was just a collection of static methods so we decided to leave them as separate functions. * Removes mock_base_api_client fixture because it was returning a Client class instance, when the class is no longer present. Something similar is necessery because now we have a repeating code in lots of places-see the issue: reanahub#219 (comment)
diegodelemos
force-pushed
the
6-api-client-creation
branch
from
27d9025 to
fe55009
Compare
diegodelemos
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects reanahub/reana-commons/issues/6