Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: create endpoints to get sharing users #429

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

DaanRosendal
Copy link
Member

@DaanRosendal DaanRosendal commented Dec 1, 2023

Adds two endpoints:

  • fetch who shared workflows with the user
  • fetch who the user shared workflows with

Closes reanahub/reana-server#648, closes reanahub/reana-server#649

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.77%. Comparing base (ebf3695) to head (3f08c0a).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   37.10%   36.77%   -0.33%     
==========================================
  Files          26       24       -2     
  Lines        1652     1626      -26     
==========================================
- Hits          613      598      -15     
+ Misses       1039     1028      -11     

see 26 files with indirect coverage changes

@DaanRosendal DaanRosendal force-pushed the feature/get-sharing-users branch 3 times, most recently from 8f5dda6 to 75c9a21 Compare March 18, 2024 10:46
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for sharing a workflow with a user.

Closes reanahub/reana-client#680
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for unsharing a workflow.

Closes reanahub/reana-client#681
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for retrieving whom a workflow is shared with.

Closes reanahub/reana-client#686
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
Adds two endpoints:
- fetch who shared workflows with the user
- fetch who the user shared workflows with

Closes reanahub/reana-server#648 and reanahub/reana-server#649
mdonadoni added a commit to DaanRosendal/reana-commons that referenced this pull request Aug 20, 2024
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for sharing a workflow with a user.

Closes reanahub/reana-client#680
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for unsharing a workflow.

Closes reanahub/reana-client#681
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for retrieving whom a workflow is shared with.

Closes reanahub/reana-client#686
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
mdonadoni pushed a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
Adds two endpoints:
- fetch who shared workflows with the user
- fetch who the user shared workflows with

Closes reanahub/reana-server#648 and reanahub/reana-server#649
mdonadoni added a commit to DaanRosendal/reana-commons that referenced this pull request Aug 29, 2024
@mdonadoni
Copy link
Member

Ready to be reviewed, squashed and merged

DaanRosendal and others added 6 commits September 4, 2024 18:12
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for sharing a workflow with a user.

Closes reanahub/reana-client#680
Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for unsharing a workflow.

Closes reanahub/reana-client#681
)

Adds `reana-server` and `reana-workflow-controller` OpenAPI
specifications for retrieving whom a workflow is shared with.

Closes reanahub/reana-client#686
…hub#429)

Adds new `shared`, `shared_with` and `shared_by` parameters to the
`get_workflows` endpoint to retrieve workflows along with their sharing
information.

Closes reanahub/reana-client#687
Adds two endpoints:
- fetch who shared workflows with the user
- fetch who the user shared workflows with

Closes reanahub/reana-server#648 and reanahub/reana-server#649
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍 with

- r-client #692
- r-client-go #153
- r-ui #375
- r-server #658
- r-workflow-controller #552
- r-commons #429
- r-db #216

Kept separate commits for the history, renamed commit headlines.

@tiborsimko tiborsimko merged commit 3f08c0a into reanahub:master Sep 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants