-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
models: replace workflow.run_number with generation and restart number #205
models: replace workflow.run_number with generation and restart number #205
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 74.24% 74.44% +0.20%
==========================================
Files 7 7
Lines 893 900 +7
==========================================
+ Hits 663 670 +7
Misses 230 230
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
reana_db/alembic/versions/20231002_1208_b85c3e601de4_separate_run_and_restart_number.py
Show resolved
Hide resolved
ef5f9d4
to
5a14407
Compare
reana_db/alembic/versions/20231002_1208_b85c3e601de4_separate_run_and_restart_number.py
Outdated
Show resolved
Hide resolved
d6eeafe
to
79f8221
Compare
58fa915
to
850065f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! Everything works well 🚀
Change the workflow table to split the run_number into two integers: one is the major run number (the number before the dot), and the other one is the minor run number (after the dot), which increases when restarting a workflow, thus removing the limit of 9 restarts. Closes reanahub#186.
850065f
to
589978b
Compare
Change the workflow table to split the run_number into two integers: one referring to the generation of the workflows, and the other one referring to the restart number, thus removing the limit of 9 restarts.
Closes #186.
To test the PR, these quick scripts might be come in handy:
1
) a certain number of times (default15
)../restart.sh 50 3
will restartroot6-roofit.3
50 times.