Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.9.2 #549

Merged
merged 5 commits into from
Dec 12, 2023
Merged

release: 0.9.2 #549

merged 5 commits into from
Dec 12, 2023

Conversation

mdonadoni
Copy link
Member

@mdonadoni mdonadoni commented Nov 30, 2023

TODO:

  • Update shared modules
  • Update requirements.txt
  • Change release date in CHANGES.rst and Dockerfile to actual release day

@mdonadoni mdonadoni marked this pull request as draft November 30, 2023 15:07
@mdonadoni mdonadoni mentioned this pull request Nov 30, 2023
30 tasks
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #549 (2ab81cb) into master (8af3f7d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          15       15           
  Lines        1382     1382           
=======================================
  Hits         1002     1002           
  Misses        380      380           
Files Coverage Δ
reana_workflow_controller/version.py 100.00% <100.00%> (ø)

@mdonadoni mdonadoni marked this pull request as ready for review December 1, 2023 12:48
@mdonadoni mdonadoni force-pushed the release-0.9.2 branch 2 times, most recently from 94d0d83 to c9ff475 Compare December 4, 2023 14:19
Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left a minor comment on the readability of one line of the changelog.

CHANGES.rst Outdated
- Changes the workflow deletion endpoint to return a different and more appropriate message when deleting all the runs of a workflow.
- Changes CVMFS support to allow users to automatically mount any available repository.
- Changes how pagination is performed in order to avoid counting twice the total number of records.
- Fixes job status consumer exception while attempting to fetch workflow engine logs for workflows that could not have been successfully scheduled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixes job status consumer exception while attempting to fetch workflow engine logs for workflows that could not have been successfully scheduled.
- Fixes job status consumer exception while attempting to fetch workflow engine logs for workflows that were not successfully scheduled.

I think the original was a bit hard to read, wdyt about this small change to improve readability?

@mdonadoni mdonadoni force-pushed the release-0.9.2 branch 2 times, most recently from 833204d to b818217 Compare December 12, 2023 15:06
Configure setuptools to use distutils provided by the standard Python
library instead of the vendored one in setuptools, so that editable
installations are stored in the right directory.
@mdonadoni mdonadoni merged commit 2ab81cb into reanahub:master Dec 12, 2023
13 checks passed
@mdonadoni mdonadoni deleted the release-0.9.2 branch December 12, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants