-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dask): Dask integration (#600) #600
base: master
Are you sure you want to change the base?
Conversation
7085bf8
to
afaab22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 75.59% 75.54% -0.05%
==========================================
Files 15 16 +1
Lines 1565 1779 +214
==========================================
+ Hits 1183 1344 +161
- Misses 382 435 +53
|
80fad13
to
309f815
Compare
1ceaaae
to
f276810
Compare
f276810
to
6171e8e
Compare
6171e8e
to
9a74917
Compare
9a74917
to
d95f80c
Compare
d95f80c
to
1672523
Compare
0e4ff9e
to
6fc1485
Compare
api_version="networking.k8s.io/v1", | ||
kind="Ingress", | ||
metadata=client.V1ObjectMeta( | ||
name=f"dask-dashboard-ingress-{cluster_name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW is dashboard exposure working already? I'm getting 404 page not found when trying out locally.
httpGet: | ||
port: http-dashboard | ||
path: /health | ||
initialDelaySeconds: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to make these hard-coded options (such as the liveness probe seconds etc) configurable via environment variables. This could come handy for some deployment scenarios. We could also do this later after the initial basic version is merged.
(Alternatively, we could think of customising the whole template, but that would surely go beyond the scope of this initial PR.)
f48ffe5
to
a14c379
Compare
49bac4b
to
8a8319f
Compare
8a8319f
to
e94f17d
Compare
e94f17d
to
cf88a46
Compare
cf88a46
to
deb1a27
Compare
deb1a27
to
b58133b
Compare
b58133b
to
6b8dff6
Compare
6b8dff6
to
e148d06
Compare
This pull request contains the ongoing work of dask integration into REANA.