Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dask): Dask integration (#600) #600

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Aug 13, 2024

This pull request contains the ongoing work of dask integration into REANA.

@Alputer Alputer self-assigned this Aug 13, 2024
@Alputer Alputer changed the title Dask integration feat(dask): Dask integration #600 Aug 13, 2024
@Alputer Alputer changed the title feat(dask): Dask integration #600 feat(dask): Dask integration (#600) Aug 13, 2024
@Alputer Alputer force-pushed the dask-integration branch 8 times, most recently from 7085bf8 to afaab22 Compare August 15, 2024 12:48
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 54 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (e36c6a2) to head (e148d06).

Files with missing lines Patch % Lines
reana_workflow_controller/dask.py 75.92% 39 Missing ⚠️
reana_workflow_controller/k8s.py 20.00% 8 Missing ⚠️
reana_workflow_controller/consumer.py 50.00% 4 Missing ⚠️
reana_workflow_controller/workflow_run_manager.py 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   75.59%   75.54%   -0.05%     
==========================================
  Files          15       16       +1     
  Lines        1565     1779     +214     
==========================================
+ Hits         1183     1344     +161     
- Misses        382      435      +53     
Files with missing lines Coverage Δ
reana_workflow_controller/config.py 93.12% <100.00%> (+1.95%) ⬆️
reana_workflow_controller/workflow_run_manager.py 80.67% <57.14%> (-0.45%) ⬇️
reana_workflow_controller/consumer.py 55.27% <50.00%> (-0.28%) ⬇️
reana_workflow_controller/k8s.py 83.82% <20.00%> (-5.07%) ⬇️
reana_workflow_controller/dask.py 75.92% <75.92%> (ø)

@Alputer Alputer force-pushed the dask-integration branch 6 times, most recently from 80fad13 to 309f815 Compare August 22, 2024 15:04
@Alputer Alputer force-pushed the dask-integration branch 2 times, most recently from 1ceaaae to f276810 Compare August 27, 2024 09:12
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Aug 28, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Aug 29, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Aug 29, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Aug 29, 2024
api_version="networking.k8s.io/v1",
kind="Ingress",
metadata=client.V1ObjectMeta(
name=f"dask-dashboard-ingress-{cluster_name}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW is dashboard exposure working already? I'm getting 404 page not found when trying out locally.

httpGet:
port: http-dashboard
path: /health
initialDelaySeconds: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to make these hard-coded options (such as the liveness probe seconds etc) configurable via environment variables. This could come handy for some deployment scenarios. We could also do this later after the initial basic version is merged.

(Alternatively, we could think of customising the whole template, but that would surely go beyond the scope of this initial PR.)

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 9, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 11, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 13, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 13, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 13, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 16, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 16, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants